Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer Tetris by Default #54

Merged
merged 1 commit into from Mar 15, 2024

Conversation

gummyfrog
Copy link
Contributor

TICKET FOR NEXT SPRINT:

Editor cleanliness errors. Users should be prompted to change the default project name before saving, the editor should ensure that there IS a metadata block before saving, and changing the project name in the file should DELETE the old workspace file OR we just use a hash as the name or something that never changes– this shouldn't ever be shown to the user. (I like this solution the most.)

Copy link
Contributor

@Snarr Snarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tuk05348 tuk05348 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jeffin-J Jeffin-J merged commit aa4acac into main Mar 15, 2024
2 of 3 checks passed
@mustafamalik-tu mustafamalik-tu deleted the BP-154-New-workspaces-have-metadata-blocks branch March 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants