Fix a bug where result urls were not updated in retry #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
commented
Apr 8, 2024
| @@ -56,7 +56,7 @@ def default_request_handler(self, environ, start_response): | |||
| status = "200 OK" | |||
| response_headers = [ | |||
| ("Content-type", "text/plain"), | |||
| ("Content-Disposition", "attachment; filename=testfile_{self.request_number}.txt"), | |||
| ("Content-Disposition", f"attachment; filename=testfile_{self.request_number}.txt"), | |||
There was a problem hiding this comment.
I assume this was supposed to be an f-string originally? Also useful in the updated test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 90.23% 90.64% +0.41%
==========================================
Files 5 5
Lines 635 663 +28
==========================================
+ Hits 573 601 +28
Misses 62 62 ☔ View full report in Codecov by Sentry. |
samaloney
commented
Apr 8, 2024
| assert ["0", "1", "3", "4", "2"] == [url[-1] for url in f2.urls] | ||
| assert "testfile_1.txt" == f2[0].split("/")[-1] | ||
| # there are two requests made per file one for size and one download? | ||
| # Todo change handler to use path to create name not request call count |
There was a problem hiding this comment.
Could either create a different test server or update to the current callback to generate the filename based on the request PATH so like filename=f'testfile_{environ['PATH']}.txt'
samaloney
force-pushed
the
bugfix-retry-urls
branch
from
64f4c0b
to
dae981b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually what prompted #152 but I forgot to implement this basic version after creating the issue, my bad.