Fixed font-related test error on some platforms #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 94.54% 95.15% +0.61%
==========================================
Files 28 28
Lines 5848 7252 +1404
Branches 1166 1598 +432
==========================================
+ Hits 5529 6901 +1372
- Misses 193 212 +19
- Partials 126 139 +13 ☔ View full report in Codecov by Sentry. |
lorenzncode
approved these changes
May 26, 2024
| @@ -24,7 +25,8 @@ | |||
| ) | |||
|
|
|||
| # test data directory | |||
| testdataDir = os.path.join(os.path.dirname(__file__), "testdata") | |||
| testdataDir = Path(os.path.dirname(__file__), "testdata") | |||
There was a problem hiding this comment.
Using only pathlib it could be:
testdataDir = Path(__file__).parent.joinpath("testdata")
testFont = str(testdataDir.joinpath("OpenSans-Regular.ttf"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the logo that is embedded in the repo for CadQuery's logo in order to prevent text alignment test failures across platforms.
Closes #1569 and #187