Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on invalid faces #1541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

openvmp
Copy link

@openvmp openvmp commented Mar 19, 2024

No description provided.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.44%. Comparing base (153ed3f) to head (036bdb6).

Files Patch % Lines
cadquery/occ_impl/shapes.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
- Coverage   94.48%   94.44%   -0.04%     
==========================================
  Files          28       28              
  Lines        5780     5782       +2     
  Branches     1071     1072       +1     
==========================================
  Hits         5461     5461              
- Misses        193      194       +1     
- Partials      126      127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

@openvmp thanks, what is the background of this fix? How can I reproduce the issue and can a test be added?

@openvmp
Copy link
Author

openvmp commented May 11, 2024

I was trying to use CadQuery to render models for PartCAD.org. Specifically this model: https://partcad.org/repository/assembly/robotics/multimodal/openvmp/robots/don1:robot

It was larger than 1GB back then. And CadQuery was crashing on some triangle. It was too much for me to find which one and why. I stopped using CadQuery for that purpose, so it's impossible to investigate any further now.

@adam-urbanczyk
Copy link
Member

Could you share this model as a .brep file?

@openvmp
Copy link
Author

openvmp commented May 11, 2024

Give me some time to add this export feature and to try reproducing the crash (I operate on much smaller models now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants