-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed font-related test error on some platforms #1577
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 94.54% 95.15% +0.61%
==========================================
Files 28 28
Lines 5848 7252 +1404
Branches 1166 1598 +432
==========================================
+ Hits 5529 6901 +1372
- Misses 193 212 +19
- Partials 126 139 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some cosmetics
@@ -24,7 +25,8 @@ | |||
) | |||
|
|||
# test data directory | |||
testdataDir = os.path.join(os.path.dirname(__file__), "testdata") | |||
testdataDir = Path(os.path.dirname(__file__), "testdata") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using only pathlib it could be:
testdataDir = Path(__file__).parent.joinpath("testdata")
testFont = str(testdataDir.joinpath("OpenSans-Regular.ttf"))
Uses the logo that is embedded in the repo for CadQuery's logo in order to prevent text alignment test failures across platforms.
Closes #1569 and #187