fix #5743 use of perl regexp vs sql like #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWitness
approved these changes
May 10, 2024
netniV
approved these changes
May 12, 2024
|
@TheWitness @netniV How do you handle this with the develop branch? Do you want me to create a pull request for the develop branch, too? |
|
Yes a separate pull request would be best. |
gvde
added a commit
to gvde/cacti
that referenced
this pull request
May 14, 2024
|
I will do a bunch of cherry picking once the code freeze is lifted @gvde |
|
@TheWitness I have already created #5749... |
|
Yea, I saw it. |
TheWitness
pushed a commit
that referenced
this pull request
May 15, 2024
TheWitness
pushed a commit
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes order of REGEXP parameters and avoids devices with empty sysDescr, sysName or sysOid to match device rules with set, non-empty matches.