Fixing #5743 - Automation Expressions SQL Handling #5744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation Expressions do not properly handle blank match strings
|
As mentioned in my comment TheWitness@79799f3 this doesn't fix the issue. |
Properly handle the regular expression.
gvde
suggested changes
May 10, 2024
There was a problem hiding this comment.
This still has a lot of issues:
- You have to use db_qstr on the expression instead of preq_quote. I would recommend a prepared statement, anyway, because it saves you all that trouble.
- You still first check if the qsysDescr, qsysObject or qsysName values from the device are empty or not. If it's empty, you omit the condition meaning match anything. This means, if I have a device rule matching for "Cisco" in sysDescr, and leaving the matches for sysObject and sysName empty, any device which has an empty sysDescr set will match the rule in addition to all devices containing "Cisco". I am pretty sure that this is not what the average user would expect. IMHO devices with an empty sysdesc, sysoid or sysname should not match just like any device which woul have an other, non-empty string.
After discussion with user, going to use prepared statement.
* After a sample run, found that the previous change was not correct. This new changes operates correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automation Expressions do not properly handle blank match strings