Fixing #5738 and #GHSA-37x7-mfjv-mm7m

* Fixing #5733 - French Translation Cacti does not work using the French Language * Update CHANGELOG * Fixing #5738 - Boost Issues with fresh install * QA: Address type juggling vulnerability in Cacti * QA: Update ChangeLog * Update CHANGELOG * Update CHANGELOG --------- Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
Cacti · May 7, 2024 · 6183961 · 6183961
1 parent f8893bf
commit 6183961
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -35,6 +35,7 @@ Cacti CHANGELOG
 -issue#5731: Saving a Tree can cause the tree to become unpublished
 -issue#5732: Web Basic Authentication does not record user logins
 -issue#5733: When using Accent-based languages, translations may not work properly
+-issue#5748: Improve PHP 8.1 Support during fresh install with boost
 -feature#5692: Add a device "enabled/disabled" indicator next to the graphs
 -feature#5710: Notify the admin periodically when a remote data collector goes into heartbeat status
 -feature#5716: Add template for Aruba Clearpass

diff --git a/lib/auth.php b/lib/auth.php
@@ -4395,7 +4395,7 @@ function compat_password_verify($password, $hash) {
 
 	$md5 = md5($password);
 
-	return ($md5 == $hash);
+	return ($md5 === $hash);
 }
 
 /**

diff --git a/poller_boost.php b/poller_boost.php
@@ -122,13 +122,17 @@
 	$boost_last_run_time = read_config_option('boost_last_run_time');
 	if (!empty($boost_last_run_time) && !is_numeric($boost_last_run_time)) {
 		$last_run_time = strtotime($boost_last_run_time);
+	} elseif (empty($boost_last_run_time)) {
+		$last_run_time = time() - 3600;
 	} else {
 		$last_run_time = $boost_last_run_time;
 	}
 
 	$boost_next_run_time = read_config_option('boost_next_run_time');
 	if (!empty($boost_next_run_time) && !is_numeric($boost_next_run_time)) {
 		$next_run_time = strtotime($boost_next_run_time);
+	} elseif (empty($boost_next_run_time)) {
+		$next_run_time = time() + 3600;
 	} else {
 		$next_run_time = $boost_next_run_time;
 	}