Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc to promote CURENT #440

Merged
merged 15 commits into from Apr 23, 2023
Merged

Update doc to promote CURENT #440

merged 15 commits into from Apr 23, 2023

Conversation

jinningwang
Copy link
Member

@jinningwang jinningwang commented Apr 13, 2023

Update CURENT logo in README and home page of documentation
Update links
Remove dependencies of GridCal

@jinningwang
Copy link
Member Author

Two errors I haven't figured out yet.

  1. Making documentation, [autosummary] failed to import andes.io.em_psse.get_signals., but there is not such a module.
  2. The CI failed because of codecov, not sure what's the reason.
ERROR: Could not find a version that satisfies the requirement codecov (from andes[all]) (from versions: none)
ERROR: No matching distribution found for codecov
Error: Process completed with exit code 1.

@cuihantao
Copy link
Collaborator

Thanks, Jinning.

For 2, you can check if codecov is still installable. There has been some changes with the company. Doing a search might point you to some news. You might consider disabling it for now and using another coverage service in the future.

For 1, I removed em_psse and probably forgot to remove some references to it in autodocs. You can use global search to find and remove them, and see if it fixes it.

@cuihantao
Copy link
Collaborator

Please also double check the README preview. I skimed through it and saw <br>

@jinningwang
Copy link
Member Author

jinningwang commented Apr 13, 2023

I have removed the codecov # Upload the report to codecov. on Linux, but there is another error when running CI that I don't have access to check and fix.

The error message:

Publishing test results to test run '17702'.
TestResults To Publish 67, Test run id:17702
Test results publishing 67, remaining: 0. Test run id: 17702
No source for code: '/home/vsts/work/1/s/(builtin)'.
##[error]Bash exited with code '1'.

@cuihantao
Copy link
Collaborator

The CURENT logo in the README is of very low resolution. Need to replace it with a high-quality PNG or SVG image, preferably with a transparent background.

The CI error is probably due to changes in GridCal. Some options to consider:

  • Fix the version of GridCal that we depend on
  • Remove dependency on GridCal; update the interop module to let the users install GridCal manually if they need it. We will lose the ability to test the interface then.

@jinningwang
Copy link
Member Author

After a brief test, I choose to remove GridCal from dependencies for now. The installation of GridCal is buggy with PySide2.
it can be added later on if the contributor of the interface with GridCal can address this dependency issue.

The CURENT logo in the README is of very low resolution. Need to replace it with a high-quality PNG or SVG image, preferably with a transparent background.

The CI error is probably due to changes in GridCal. Some options to consider:

  • Fix the version of GridCal that we depend on
  • Remove dependency on GridCal; update the interop module to let the users install GridCal manually if they need it. We will lose the ability to test the interface then.

@cuihantao
Copy link
Collaborator

Can you resize the CURENT logo...

@cuihantao cuihantao merged commit c050f89 into CURENT:develop Apr 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants