Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup k8s configs and deploy to production #114

Merged
merged 40 commits into from Nov 3, 2022
Merged

Setup k8s configs and deploy to production #114

merged 40 commits into from Nov 3, 2022

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented Oct 13, 2022 •
edited

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance or refactor
  • Test
  • DevOps
  • Others:

Overview of changes

Fixes #76
Fixes #118
Fixes #136
Fixes #137
Fixes #139
Fixes #138

Main:

  • Create all relevant k8s configs
  • Adjust cors/port settings
  • Experiment and finalize on both local and cloud deployment strategy
  • Update GitHub Action script for CD

FYI:
kubernetes/kubernetes#33664

Minor updates:

  • Fix microservice docker files and Nginx config for Kubernetes deployment

How it was tested/How to test

  • Cloud deployment was tested via the production branch.
  • Local k8s development can be tested by following the instructions in k8s/init.sh

Can check that local deployment still works, and cloud deployment at leetwithfriend.com works

Service(s) Touched

  • Frontend
  • User Service
  • Matching Service
  • Question Service
  • Collaboration Service

@tlylt tlylt changed the title Setup k8s configs [WIP] Setup k8s configs Oct 13, 2022
@tlylt tlylt added this to the v3.0 milestone Oct 13, 2022
@tlylt tlylt changed the title [WIP] Setup k8s configs Setup k8s configs Oct 18, 2022
@tlylt tlylt marked this pull request as ready for review October 18, 2022 16:00
@tlylt tlylt changed the title Setup k8s configs Setup k8s configs and deploy to production Oct 25, 2022
@tlylt tlylt enabled auto-merge (squash) October 25, 2022 07:27
@tlylt tlylt requested review from MarcusTXK, Hzxin and uyencfi and removed request for MarcusTXK October 25, 2022 07:28
MarcusTXK
MarcusTXK approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job with all the deployment config

@tlylt tlylt merged commit 8c7579f into main Nov 3, 2022
@tlylt tlylt deleted the init-deploy branch November 3, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusTXK MarcusTXK MarcusTXK approved these changes

@Hzxin Hzxin Awaiting requested review from Hzxin

@uyencfi uyencfi Awaiting requested review from uyencfi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
2 participants
@tlylt @MarcusTXK