Skip to content

Commit

Permalink
Merge pull request #134 from yash-chowdhary/fixes
Browse files Browse the repository at this point in the history
Fix task viewing
  • Loading branch information
amrut-prabhu committed Mar 28, 2018
2 parents a272966 + 79cdedb commit 7707f1d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/main/java/seedu/club/logic/commands/LogOutCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public CommandResult execute() {
} else {
model.logOutMember();
model.updateFilteredMemberList(Model.PREDICATE_NOT_SHOW_ALL_MEMBERS);
model.updateFilteredTaskList(Model.PREDICATE_NOT_SHOW_ALL_TASKS);
return new CommandResult(MESSAGE_SUCCESS);
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/seedu/club/model/Model.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,12 @@ public interface Model {
Predicate<Member> PREDICATE_SHOW_ALL_MEMBERS = unused -> true;


/** {@code Predicate} that always evaluate to false */
/** {@code Predicate} that always evaluate to true */
Predicate<Task> PREDICATE_SHOW_ALL_TASKS = unused -> true;

/** {@code Predicate} that always evaluate to false */
Predicate<Task> PREDICATE_NOT_SHOW_ALL_TASKS = unused -> false;

/** {@code Predicate} that always evaluate to true */
Predicate<Member> PREDICATE_NOT_SHOW_ALL_MEMBERS = unused -> false;

Expand Down
5 changes: 3 additions & 2 deletions src/main/java/seedu/club/model/ModelManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public ModelManager(ReadOnlyClubBook clubBook, UserPrefs userPrefs) {
filteredPolls = new FilteredList<>(this.clubBook.getPollList());
filteredTasks = new FilteredList<>(this.clubBook.getTaskList());
updateFilteredMemberList(PREDICATE_NOT_SHOW_ALL_MEMBERS);
updateFilteredTaskList(PREDICATE_NOT_SHOW_ALL_TASKS);
}

public ModelManager() {
Expand Down Expand Up @@ -137,7 +138,7 @@ public void logsInMember(String username, String password) {
clubBook.logInMember(username, password);
if (getLoggedInMember() != null) {
updateFilteredMemberList(PREDICATE_SHOW_ALL_MEMBERS);
// updateFilteredTaskList(PREDICATE_SHOW_ALL_TASKS);
updateFilteredTaskList(PREDICATE_SHOW_ALL_TASKS);
}
}

Expand Down Expand Up @@ -301,7 +302,7 @@ public void addTaskToTaskList(Task toAdd) throws DuplicateTaskException {
toAdd.setAssignee(assignee);
toAdd.setStatus(status);
clubBook.addTaskToTaskList(toAdd);
// updateFilteredTaskList(PREDICATE_SHOW_ALL_TASKS);
updateFilteredTaskList(PREDICATE_SHOW_ALL_TASKS);
indicateClubBookChanged();
} catch (DuplicateTaskException dte) {
throw new DuplicateTaskException();
Expand Down

0 comments on commit 7707f1d

Please sign in to comment.