顯示且能修改時區的議程表 #15
Open
顯示且能修改時區的議程表 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileychh
force-pushed
the
time-zone-filter
branch
from
44372a1
to
a4aebd6
Compare
mirumodapon
requested changes
Apr 30, 2024
src/modules/session/logic.ts
Outdated
| @@ -171,7 +168,7 @@ export function generateScheduleTable (elements: ScheduleElement[]): ScheduleTab | |||
| const { hour, minute } = getPartsOfDate(d) | |||
| return timePoints.findIndex(([h, m]) => h === hour && m === minute) | |||
| }) | |||
| const span = endIndex - startIndex | |||
| const span = Math.abs(endIndex - startIndex) | |||
There was a problem hiding this comment.
我不確定這個修改的作用，它也是搬過來的 😅
該留著還是改回來？
| :options="timeZoneOptions" | ||
| v-model="currentTimeZone" | ||
| /> | ||
| <button |
| @@ -68,6 +69,10 @@ export default defineComponent({ | |||
| sessionId: { | |||
| type: String, | |||
| required: true | |||
| }, | |||
| currentTimeZone: { | |||
為了在 教室列表 （
雖然不知道為什麼無法置中，但大概用
搞定。 |
z-index 設成 0 看起來 OK，教室列表之上是什麼意思啊 |
|
|
1. 將TIMEZONE_OFFSET加入useSession 2. 新增watch觀測TIMEZONE_OFFSET並重新渲染 Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <chengxuanjhe@gmail.com>
Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <chengxuanjhe@gmail.com
Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <chengxuanjhe@gmail.com>
1. 移除未使用的程式碼 2. 將 `@types/lodash` 替換成 `@types/lodash-es`
- 使用 `vue-search-select` 作為時區選擇元件 - 更新 `typescript` 到 `5.1` 以支援 `Intl.supportedValuesOf`
rileychh
force-pushed
the
time-zone-filter
branch
from
fb51b6f
to
347e4e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
從 COSCUP/2022 #21 搬過來的 PR，合併了衝突，還沒測試過。
Closes #2.