Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Easi-4281] incorporate new fields #2571

Merged
merged 16 commits into from
May 15, 2024
Merged

[Easi-4281] incorporate new fields #2571

merged 16 commits into from
May 15, 2024

Conversation

samoddball
Copy link
Contributor

@samoddball samoddball commented May 6, 2024 •
edited

EASI-4281

Changes and Description

  • Incorporate the newly added fields from CEDAR
  • These can now be accessed by the UI (but that is not added in this PR)
  • Adds two fields needed by EASI-3640 spike

How to test this change

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@samoddball samoddball marked this pull request as ready for review May 6, 2024 23:41
@samoddball samoddball requested a review from a team as a code owner May 6, 2024 23:41
@samoddball samoddball requested review from mynar7 and removed request for a team May 6, 2024 23:41
@samoddball samoddball requested a review from a team as a code owner May 6, 2024 23:43
@StevenWadeOddball StevenWadeOddball removed the request for review from a team May 7, 2024 18:54
mynar7
mynar7 reviewed May 8, 2024
View reviewed changes
EASI.postman_collection.json Outdated Show resolved Hide resolved
@samoddball samoddball requested a review from mynar7 May 8, 2024 21:48
ClayBenson94
ClayBenson94 requested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Might just want to make a few small mock data / doc changes, but other than that I think this is all set!

pkg/local/cedarcoremock/system_maintainer_information.go Outdated Show resolved Hide resolved
pkg/graph/schema.graphql Show resolved Hide resolved
ClayBenson94
ClayBenson94 previously approved these changes May 15, 2024
View reviewed changes
@samoddball samoddball merged commit 973afc3 into main May 15, 2024
13 checks passed
@samoddball samoddball deleted the EASI-4281/incorporate_new_fields branch May 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayBenson94 ClayBenson94 ClayBenson94 approved these changes

@mynar7 mynar7 Awaiting requested review from mynar7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samoddball @ClayBenson94 @mynar7