Remove db_clean service from docker-compose.yml #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race condition between these two containers was causing the database to sometimes get cleaned after migrations had been run. Rather than hack together scripts to track this state I'm simply removing the clean service from the docker-compose configuration. See also: * https://docs.docker.com/compose/startup-order/ * docker/compose#374
Igarfinkle
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-340
Changes proposed in this pull request:
A race condition between the migration containers was causing the database to sometimes get cleaned after migrations had been run. Rather than hack together scripts to track this state I'm simply removing the clean service from the docker-compose configuration.
See also:
Note: After pulling this change locally, start once with
docker-compose up --remove-orphansto clear out the orphaned db_clean image. After that, the services can be started normally with justdocker-compose up.