Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WNMGDS-2724] ds-choice-list web component #3081

Merged
merged 20 commits into from May 14, 2024
Merged

[WNMGDS-2724] ds-choice-list web component #3081

merged 20 commits into from May 14, 2024

Conversation

zarahzachz
Copy link
Collaborator

WNMGDS-2724

  • Create ChoiceList web component, stories and tests
  • Add capability for web component to accept children as HTML elements (only <ds-choice>)

@zarahzachz zarahzachz added Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Added Indicates a new feature. labels May 11, 2024
@zarahzachz zarahzachz added this to the 11.0.0-beta.1 milestone May 11, 2024
@zarahzachz zarahzachz requested a review from pwolfert May 11, 2024 00:03
pwolfert
pwolfert requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@pwolfert pwolfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this was going well until I discovered a bug I created. I've also highlighted a spot where you'll need to account for some other kinds of children your parser might encounter.

packages/design-system/src/components/web-components/ds-choice-list/ds-choice-list.stories.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/web-components/ds-choice-list/ds-choice-list.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/web-components/ds-choice-list/ds-choice-list.stories.tsx Show resolved Hide resolved
@zarahzachz zarahzachz requested a review from pwolfert May 13, 2024 21:00
pwolfert
pwolfert reviewed May 13, 2024
View reviewed changes
.../browser/snapshots/stories/web-components-choicelist--html-choices-cmsgov--Mobile-Chrome.png Outdated Show resolved Hide resolved
packages/design-system/src/components/web-components/ds-choice-list/ds-choice-list.stories.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/web-components/ds-choice-list/ds-choice-list.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/web-components/ds-choice-list/ds-choice-list.test.tsx
Comment on lines +79 to +82
<ds-choice-list type="checkbox">
<ds-choice label="Foo" value="foo"></ds-choice>
<ds-choice label="Bar" value="bar"></ds-choice>
</ds-choice-list>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pwolfert pwolfert modified the milestones: 11.0.0-beta.1, 10.1.0 May 13, 2024
@zarahzachz zarahzachz requested a review from pwolfert May 14, 2024 19:32
pwolfert
pwolfert approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@pwolfert pwolfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great!

@zarahzachz zarahzachz merged commit 1cd2a7c into main May 14, 2024
1 check passed
@zarahzachz zarahzachz deleted the WNMGDS-2724/choicelist-wc branch May 14, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwolfert pwolfert pwolfert approved these changes

Assignees
No one assigned
Labels
Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Added Indicates a new feature.
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zarahzachz @pwolfert