Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LHDM-2201] Header/Footer Custom classes/IDs #2860

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

seesleestak
Copy link
Collaborator

Summary

  • Our team has a specific Smartling-related requirement to be able to assign class names and IDs to the logo, language switch link, and log in link in the Header and the logo in the Footer.
  • https://jira.cms.gov/browse/LHDM-2201

How to test

For testing, I'd added props for all the ids/classes on a storybook story to verify

export const LoggedOutHeader: Story = {
  args: {
    customIds: {
      headerLogo: 'custom-header-id',
      languageLink: 'custom-language-link-id',
      loginLink: 'custom-language-login-id',
    },
    customClassNames: {
      headerLogo: 'custom-header-class',
      languageLink: 'custom-language-link-class',
      loginLink: 'custom-language-login-class',
    }
  },
};

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

If this is a change to design:

  • If visual regression image references have been changed, design MUST be assigned to review. In this instance, designer approval is a requirement before the PR can be merged.

If this is a change to code:

  • Created or updated unit tests to cover any new or modified code
  • If necessary, updated unit-test snapshots (yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)

If this is a change to documentation:

  • Checked for spelling and grammatical errors

@seesleestak seesleestak added Impacts: Healthcare Impacts the Healthcare.gov theme directly. Type: Changed Indicates a change to an existing element of the DS. labels Dec 29, 2023
@seesleestak
Copy link
Collaborator Author

I ran yarn test:browser:update but the changes I saw locally didn't seem related to the PR changes or the build error. Any help deciphering that would be appreciated.

@forrestbaer forrestbaer removed their request for review January 6, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Healthcare Impacts the Healthcare.gov theme directly. Type: Changed Indicates a change to an existing element of the DS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant