[NO-TICKET] Use the external link component in doc site #2522
+56
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we're going to need to refine the component's styles in order for it to work well
4 tasks
Our argument for using a link is that even though it doesn't perform the navigation directly (normal a11y rule for using a button instead of a link), the intent of the element is to perform navigation, which makes it a link. This also allows desktop users to hover over the link and see the address, and it allows some other standard browser behaviors. It is also way easier to style to look like a link, because it is a link. We realized we were going to have to fix the styles anyway because its primary use case is to be within blocks of text.
zarahzachz
approved these changes
Jun 8, 2023
forrestbaer
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we're going to need to refine the component's styles. I'm putting up this PR early so we have a place to discuss changes we might need to make to that component.
Examples of the problem with using it as-is in blocks of text:
Summary
How to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)If this is a change to documentation: