Added CRYP-7932 to determine if the system has enabled macOS FileVault. #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboelen
requested changes
May 14, 2024
There was a problem hiding this comment.
Looks like a good start! A few suggestions to make it better:
- Move the "filevault_status" directory into the
case, as nothing is done with the variable - Do a check if fdesetup exists. Maybe it does exist on macOS now, but that might change in the future.
- Add some hardening points (AddHP). I would suggest 3 of 3 when enabled, 0 of 3, when not.
- Now checks if "fdesetup" exists - Add some hardening points (AddHP): 3 of 3 when enabled, 0 of 3, when not.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code will check if macOS FileVault is enabled.