Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test MALW-3291 in order to solve issue 1322 #1384

Merged
merged 1 commit into from May 14, 2024

Conversation

xnoguer
Copy link
Contributor

@xnoguer xnoguer commented Apr 18, 2023

I added a new test (id MALW-3291) in order to solve issue 1322. This is related to issue 994.

A few notes:

  • I could have just considered whether MDATPBINARY was set or not (in include/binaries) and use that as a condition to set (or unset) MALWARE_SCANNER_INSTALLED in include/tests_malware. But I thought that adding a new test for mdatp was a cleaner solution. If I was wrong, please don't hesitate to tell me so.
  • Tried to respect what I think is the criteria for assigning ids to new tests. Again, if assigned a wrong id to the new test, please don't hesitate to tell me so.
  • Tested as thoroughly as I could (Debian 11), but more testing would be welcome.

@alexander-krug
Copy link

@xnoguer I am having the same issue as you and #1322 and like your clean approach to using the "malware_scanner_installed" variable to solve the problem.

I performed a recent run on my system with mdatp installed, enabled and running. Lynis reports "Result: no malware scanner found" just as #1322.

/var/log/lynis.log shows:
2023-09-02 20:38:29 Starting Lynis 3.0.6 with PID 2823, build date 2021-07-22 (...) 2023-09-02 20:38:36 Found known binary: mdatp (Microsoft Defender ATP, malware scanner) - /usr/bin/mdatp (...) 2023-09-02 20:39:21 Performing test ID HRDN-7230 (Check for malware scanner) 2023-09-02 20:39:21 Test: Check if a malware scanner is installed 2023-09-02 20:39:21 Result: no malware scanner found

/var/log/lynis-report.dat shows:
malware_scanner_installed=0

https://github.com/CISOfy/lynis/blob/master/include/tests_malware is missing a test to set malware_scanner_installed to 1 if mdatp is installed. This commit should fix this.

@GuizmoPhil
Copy link

I'm having the same issue with Lynis version 3.1.1. MDATP (Microsoft Defender) isn't recognized as a malware scanner.

System is running Ubuntu 20.04, which is based on Debian 10.

@xnoguer
Copy link
Contributor Author

xnoguer commented Apr 8, 2024

@mboelen Could you take a look at this?

@mboelen mboelen merged commit 6cbea90 into CISOfy:master May 14, 2024
@mboelen mboelen self-assigned this May 14, 2024
@mboelen
Copy link
Member

mboelen commented May 14, 2024

Looks good, so I have merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants