Fix manual sending usage, clientside caching and rate limiting

moon/autorun/client/cfc_err_fwd.moon

@@ -4,7 +4,19 @@ hook.Add "Think", "CFC_ErrForwarder_BranchInit", ->
     net.WriteString BRANCH
     net.SendToServer!
 
+bucket = 4
+sendCache = {}
 hook.Add "OnLuaError", "CFC_ErrForwarder_OnLuaError", (errorString, _, stack) ->
+    -- TODO: Queue errors that happen before the setting has been received?
+    return unless GetGlobal2Bool "CFC_ErrorForwarder_ManualSend", false
+
+    return if bucket <= 0
+
+    now = CurTime!
+    expires = sendCache[errorString] or now
+    return if expires > now
+    sendCache[errorString] = now + 5
+
     net.Start "cfc_err_forwarder_clerror"
     net.WriteString errorString
 
@@ -18,3 +30,8 @@ hook.Add "OnLuaError", "CFC_ErrForwarder_OnLuaError", (errorString, _, stack) ->
         net.WriteString level.Line
 
     net.SendToServer!
+
+    bucket -= 1
+
+timer.Create "CFC_ErrForwarder_BucketReset", 1, 0, ->
+    bucket += 1 if bucket < 4

moon/autorun/server/cfc_err_fwd.moon

@@ -1,12 +1,13 @@
 require "reqwest"
 
 useErrorModule = false
-if util.IsBinaryModuleInstalled "luaerror"
+if false and util.IsBinaryModuleInstalled "luaerror"
     require "luaerror"
     luaerror.EnableCompiletimeDetour true
     luaerror.EnableClientDetour true
     luaerror.EnableRuntimeDetour true
     useErrorModule = true
+SetGlobal2Bool "CFC_ErrorForwarder_ManualSend", not useErrorModule
 
 util.AddNetworkString "cfc_err_forwarder_clbranch"
 util.AddNetworkString "cfc_err_forwarder_clerror"

moon/cfc_err_forwarder/error_forwarder.moon

@@ -145,7 +145,7 @@ return class ErrorForwarder
         @queueError isRuntime, fullError, sourceFile, sourceLine, errorString, stack, ply
 
     logErrorInfo: (isRuntime, fullError, sourceFile, sourceLine, errorString, stack) =>
-        debug = @logger\info
+        debug = @logger\debug
 
         debug "Is Runtime: #{isRuntime}"
         debug "Full Error: #{fullError}"