Support TYPE_ENUM for beA expectation #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonsturgeon
approved these changes
Jul 11, 2023
brandonsturgeon
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Actually, one quick thing we need to do:
Could you update the expectation docs in the README to indicate that it also takes a TYPE enum?
https://github.com/CFC-Servers/GLuaTest/blob/main/README.md#expectations
The Readme is an absolute mess to read through because of all of the dropdowns and stuff. Ctrl-f should get you there easily though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
beA(+beAn) to support TYPE enum as well as strings.It also removes useless
beAnfunction from the negative expectations, and replaces it with a reference tobeAmirroring the positive expectations file.