fluids: Refactor primary Ceed Object creation routines #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwrigh
force-pushed
the
jrwrigh/refactor_setuplibceed
branch
3 times, most recently
from
289a5af
to
3397430
Compare
jrwrigh
force-pushed
the
jrwrigh/refactor_setuplibceed
branch
from
3397430
to
27ea4a7
Compare
And some other misc style changes
jrwrigh
force-pushed
the
jrwrigh/refactor_setuplibceed
branch
from
27ea4a7
to
a5b0ec6
Compare
jeremylt
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Currently draft for testing purposes)
Also known as the war against global structs.
Fixing up things such as:
Misc TODOs:
RenameI'll wait on this until I figure out which ones are going to be kept anywaysapply_vol_rhstospec_vol_rhs(and so forth for the other similar ones)Create function for creating Qdata (ie. Separate the setup functions and other info from everything else)Moved to fluids: Add CreateQData and CreateQDataBoundary functions #1571 as it's very extensive.ceed_data->qf_setup_sur, which is used by the spanstats setup