Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluids: Use State in blasius context #1566

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fluids: Use State in blasius context #1566

merged 1 commit into from
Apr 25, 2024

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Apr 25, 2024 •
edited

Instead of storing velocity, temperature, and pressure separately, just store a State struct.

Also clarifies usage of P0 in the NewtonianIdealGasContext struct.

@jrwrigh jrwrigh self-assigned this Apr 25, 2024
@jrwrigh jrwrigh changed the title fluids: Use StatePrimitive in blasius context fluids: Use State in blasius context Apr 25, 2024
@jrwrigh jrwrigh requested a review from jeremylt April 25, 2024 18:06
jeremylt
jeremylt approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jeremylt jeremylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable to me

@jrwrigh jrwrigh merged commit 8e16760 into main Apr 25, 2024
28 checks passed
@jrwrigh jrwrigh deleted the jrwrigh/blasius_state branch April 25, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylt jeremylt jeremylt approved these changes

Assignees

@jrwrigh jrwrigh

Labels
1-In Review examples minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrwrigh @jeremylt