Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEED_STRIDES_BACKEND related updates #1463

Merged
merged 5 commits into from
Feb 10, 2024
Merged

CEED_STRIDES_BACKEND related updates #1463

merged 5 commits into from
Feb 10, 2024

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Feb 2, 2024

I have two four changes here

  1. Expanded note in the documentation about CEED_STRIDES_BACKEND

  2. Set CEED_STRIDES_BACKEND to be different for memcheck than the default layouts for both CPU and GPU

  3. Add CeedElemRestrictionGetLLayout for strided restrictions

  4. Fix CeedElemRestrictionGet[L,E]Layout signature, previously there ways an unneeded pointer

This won't provide a clear warning message, but it will at least demonstrate bugs if a user mixes and matches memcheck CEED_STRIDES_BACKEND with other backends.

I don't think we can be really any clearer with the name that CEED_STRIDES_BACKEND is specific to the backend?

Offering CeedElemRestrictionGetLLayout probably fixes the root cause of why someone would see this problem though.

See #1460

Note: if we like this, a666b53, 0e6bd4c, and 32058e1 should be squashed together

Also note: if we like CeedElemRestrictionGetLLayout, I'll go add some quick unit test

@jeremylt jeremylt changed the title Unique strides for memcheck backends CEED_STRIDES_BACKEND related updates Feb 5, 2024
Copy link
Member

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level. Thanks for solving this problem. I take it we aren't enforcing anything new outside the memcheck backend?

@jeremylt
Copy link
Member Author

jeremylt commented Feb 10, 2024

I take it we aren't enforcing anything new outside the memcheck backend?

The only thing that is disruptive is f447f4b - really this function signature should have never had a pointer to an array. Its not a big change for users and I think we should fix.

We aren't forcing any changes in how the current API behaves past that.

@jeremylt jeremylt merged commit 72e72e0 into main Feb 10, 2024
28 checks passed
@jeremylt jeremylt deleted the jeremy/memcheck-strides branch February 10, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants