-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 2.8 release #4
Conversation
zachcp
commented
Sep 20, 2022
•
edited
edited
- add a Makefile for creating unbundled CDK jar files
- use sed to remove large, unused JARs
- manually add Google guava which is a hidden dep in rCDK code (used in several locations so removing might cause breaks)
- bumpversion
- ref Get the bundled JAR size under control cdk/cdk#911
- ref a minimized set of JARs for rCDK cdk/cdk#915 (comment)
- size ~27Mb (similar to previous)
Ah I would do this with a little maven stub project :). But sure sed works as well |
Probably worth seeing if we can get rid of the Guava dep. - it was mainly for convenience |
I got rid of Guava in CDK in 2.7 I think, do you use this independently? |
The mulitmap is easy to replace, since 1.8: map.computeIfAbsent(key, k -> new ArrayList<>()); |
thanks, John. I modified that file based on your suggestion (PR here; eyeballs welcome) and removed Guava here. If things look good to you both I can move forward with submitting a new release of both packages. |
@rajarshi can you squash merge this (or give me write access) |
Just merged it. Also happy to give you write access - where do I set that? |
OK, you're an admin now, so i think that gives yiou write access to everything |