Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.8 release #4

Merged
merged 11 commits into from
Sep 25, 2022
Merged

Prepare for 2.8 release #4

merged 11 commits into from
Sep 25, 2022

Conversation

zachcp
Copy link
Contributor

@zachcp zachcp commented Sep 20, 2022

@johnmay
Copy link

johnmay commented Sep 20, 2022

Ah I would do this with a little maven stub project :). But sure sed works as well

@rajarshi
Copy link
Collaborator

Probably worth seeing if we can get rid of the Guava dep. - it was mainly for convenience

@johnmay
Copy link

johnmay commented Sep 20, 2022

I got rid of Guava in CDK in 2.7 I think, do you use this independently?

@zachcp
Copy link
Contributor Author

zachcp commented Sep 20, 2022

When I took Guava out of rcdklibs, the rcdk tests failed. Its at least used here. @rajarshi if you refactor that in the 2.8 branch of rcdk, I can update the libs to remove guava.

@johnmay
Copy link

johnmay commented Sep 20, 2022

The mulitmap is easy to replace, since 1.8: map.computeIfAbsent(key, k -> new ArrayList<>());

@zachcp
Copy link
Contributor Author

zachcp commented Sep 21, 2022

thanks, John. I modified that file based on your suggestion (PR here; eyeballs welcome) and removed Guava here. If things look good to you both I can move forward with submitting a new release of both packages.

@zachcp zachcp marked this pull request as ready for review September 25, 2022 17:58
@zachcp
Copy link
Contributor Author

zachcp commented Sep 25, 2022

@rajarshi can you squash merge this (or give me write access)

@rajarshi rajarshi merged commit 55dbd00 into CDK-R:master Sep 25, 2022
@rajarshi
Copy link
Collaborator

Just merged it. Also happy to give you write access - where do I set that?

@zachcp
Copy link
Contributor Author

zachcp commented Sep 26, 2022

You can set permission levels for individuals or groups within GitHub Settings.

image

@zachcp zachcp deleted the 2022-unbundle branch September 26, 2022 13:18
@rajarshi
Copy link
Collaborator

OK, you're an admin now, so i think that gives yiou write access to everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants