Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add argument parsing in ccextractor rust #1547

Open
wants to merge 110 commits into
base: master
Choose a base branch
from

Conversation

prateekmedia
Copy link
Contributor

@prateekmedia prateekmedia commented Jul 28, 2023

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Rewrote argument parsing with all the structs and enums too into rust.

Help arguments demo:
image

@prateekmedia prateekmedia changed the title [FEAT] Add arguments in ccextractor rust [FEAT] Add arguments parsing in ccextractor rust Jul 28, 2023
@prateekmedia prateekmedia changed the title [FEAT] Add arguments parsing in ccextractor rust [FEAT] Add argument parsing in ccextractor rust Jul 28, 2023
@prateekmedia prateekmedia marked this pull request as ready for review August 9, 2023 17:18
Copy link
Member

@PunitLodha PunitLodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gone over the formatting issues for now. Haven't looked at the logic yet.
Please also try to fix the clippy warnings

src/rust/src/params.rs Outdated Show resolved Hide resolved
src/rust/src/params.rs Outdated Show resolved Hide resolved
src/rust/src/params.rs Outdated Show resolved Hide resolved
src/rust/src/params.rs Outdated Show resolved Hide resolved
src/rust/src/params.rs Outdated Show resolved Hide resolved
src/rust/src/params.rs Outdated Show resolved Hide resolved
src/rust/src/structs.rs Outdated Show resolved Hide resolved
src/lib_ccx/lib_ccx.h Outdated Show resolved Hide resolved
@prateekmedia
Copy link
Contributor Author

cc @cfsmp3 @canihavesomecoffee, The tests are all with 0's as they are ran on C code, which uses old params and not on rust code.
Rust code is already unit tested but still after C parameter PR is merged this can also be rebased and merged so its all good from my side. Already reviewed by @PunitLodha

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit bce63b8...:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/86
Teletext 0/21
WTV 0/13
XDS 0/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:


Check the result page for more info.

@prateekmedia prateekmedia marked this pull request as draft January 15, 2024 13:31
@prateekmedia
Copy link
Contributor Author

prateekmedia commented Jan 15, 2024

It seems not to be working. This is the issue:

Invalid option to CCextractor Library

@prateekmedia prateekmedia mentioned this pull request Feb 4, 2024
10 tasks
@prateekmedia
Copy link
Contributor Author

This PR needs to implement these methods to let tests run:
add_file_sequence
append_file_to_queue

Or use these existing methods from c as extern.

@prateekmedia prateekmedia marked this pull request as ready for review April 14, 2024 15:17
@prateekmedia
Copy link
Contributor Author

So now the Args are parsing correctly but the processing output is not visible.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:

Report Name Tests Passed
Broken 11/13
CEA-708 2/14
DVB 2/7
DVD 3/3
DVR-MS 2/2
General 3/27
Hauppage 0/3
MP4 1/3
NoCC 10/10
Options 5/86
Teletext 1/21
WTV 8/13
XDS 2/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants