New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add argument parsing in ccextractor rust #1547
base: master
Are you sure you want to change the base?
Conversation
af70420
to
86d0cb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gone over the formatting issues for now. Haven't looked at the logic yet.
Please also try to fix the clippy warnings
cc @cfsmp3 @canihavesomecoffee, The tests are all with 0's as they are ran on C code, which uses old params and not on rust code. |
9cefe91
to
dee7d41
Compare
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit bce63b8...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Check the result page for more info. |
It seems not to be working. This is the issue:
|
This PR needs to implement these methods to let tests run: Or use these existing methods from c as extern. |
So now the Args are parsing correctly but the processing output is not visible. |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Rewrote argument parsing with all the structs and enums too into rust.
Help arguments demo: