Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common postinst hostname check #100

Merged
merged 2 commits into from Sep 1, 2017
Merged

Add common postinst hostname check #100

merged 2 commits into from Sep 1, 2017

Conversation

patch0
Copy link
Contributor

@patch0 patch0 commented Sep 1, 2017 •
edited

This adds .localdomain to unqualified hostnames.

Closes #57

@patch0 patch0 requested a review from telyn September 1, 2017 08:31
@telyn
Copy link
Contributor

telyn commented Sep 1, 2017

Is this all that's needed? Will blah.localdomain also serve requests for blah? Also, is that what users expect and does it matter if it doesn't serve requests for blah?

@patch0
Copy link
Contributor Author

patch0 commented Sep 1, 2017

No, blah.localdomain will not serve requests for just blah, but I don't think that matters too much. I don't think people would expect that to be the case.

@telyn telyn merged commit 518b513 into stretch Sep 1, 2017
@patch0 patch0 deleted the strech-fix-common-hostname-check branch September 5, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telyn telyn Awaiting requested review from telyn

Assignees

@telyn telyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patch0 @telyn