Add environments PUID/PGID of /var/lib/dav folder.
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to set the default umask / chmod of files, which are uploaded through an WebDAV client
Add optional umask to docker-entrypoint.sh
|
This looks good to me. This PR would open up a lot of possibilities (mounting system directories, particularly VM shared folders, etc). Can a contributor take a look or approve / merge as well? |
tkodev
reviewed
Mar 25, 2022
| @@ -48,6 +48,8 @@ services: | |||
| AUTH_TYPE: Digest | |||
| USERNAME: alice | |||
| PASSWORD: secret1234 | |||
| PUID: 1000 | |||
| GUID: 1000 | |||
There was a problem hiding this comment.
Suggestion: A good idea to add PUMASK in the compose example here. ex PUMASK: ???
tkodev
reviewed
Mar 25, 2022
| @@ -104,4 +106,7 @@ All environment variables are optional. You probably want to at least specify `U | |||
| * **`PASSWORD`**: Authenticate with this password (and the username above). This is ignored if you bind mount your own authentication file to `/user.passwd`. | |||
| * **`ANONYMOUS_METHODS`**: Comma-separated list of HTTP request methods (eg, `GET,POST,OPTIONS,PROPFIND`). Clients can use any method you specify here without authentication. Set to `ALL` to disable authentication. The default is to disallow any anonymous access. | |||
| * **`SSL_CERT`**: Set to `selfsigned` to generate a self-signed certificate and enable Apache's SSL module. If you specify `SERVER_NAMES`, the first domain is set as the Common Name. | |||
| * **`PUID`**: file owner's UID of `/var/lib/dav` | |||
| * **`PGID`**: file owner's GID of `/var/lib/dav` | |||
There was a problem hiding this comment.
Suggestion: Likewise here add the description for PUMASK. ex PUMASK: umask of /var/lib/dav/data
JadinHeaston
added a commit
to JadinHeaston/docker-webdav
that referenced
this pull request
Jan 6, 2023
Signed-off-by: Jadin Heaston <jadin.heaston@como.gov>
|
Hi there, will this PR be merged some day? :D @tkodev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a easy way to change the data folder's owner, Fix issues #24 #27