2018 edition #176
Open
2018 edition #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lespea
commented
Apr 8, 2019
BurntSushi
requested changes
Apr 22, 2019
|
Okay let me know if you'd like anything else changed. |
|
Is there anything else you need for this to get merged? |
|
nudge? |
To support the update, rust 1.36.0 is now the minimum suported version (up from 1.28.0)
|
Update the libraries again to the latest versions, cleaned up the imports + unneeded lifetimes, fixed (or disabled) the remaining clippy lints. Had to bump the version to 1.36.0 for some of the library updates, but that version is pretty old by now so didn't think it would be an issue. Let me know if you need me to do anything else for this to be merged... |
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the dependencies and switched to the 2018 edition. You might want to look at the "Fix failing test" commit as I wasn't sure exactly what was going on there.