New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up ripgrep for compilation on non-unix, non-windows platforms #2787
Changes from 4 commits
2954e42
c57995e
9a3b871
c7ceb29
64be256
37a5fd5
5cb3883
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -853,6 +853,13 @@ impl HyperlinkPath { | |
} | ||
HyperlinkPath(result) | ||
} | ||
|
||
// For other platforms (not windows, not unix), return None and log a debug message. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And please move this to be directly below the other There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes have been incorporated. |
||
#[cfg(not(any(windows, unix)))] | ||
pub(crate) fn from_path(original_path: &Path) -> Option<HyperlinkPath> { | ||
log::debug!("Hyperlinks are not supported on this platform"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be consistent with other log messages, could you please use "hyperlinks" instead of "Hyperlinks"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is done. |
||
None | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did running tests via
wasmtime
fail? If so this is fine, but if they worked, then we should just include them here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, running tests via
wasmtime
does fail (but compilation works):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah fair enough. We can save that for another day.