Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #2754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: fix some comments #2754

wants to merge 1 commit into from

Conversation

tgolang
Copy link

@tgolang tgolang commented Mar 11, 2024

No description provided.

@Flowrey
Copy link

Flowrey commented Mar 22, 2024

There is also a trailing parenthesis at L31

/// Like eprintln, but locks stdout to prevent interleaving lines.
///
/// This locks stdout, not stderr, even though this prints to stderr. This
/// avoids the appearance of interleaving output when stdout and stderr both
/// correspond to a tty.)

@atouchet
Copy link
Contributor

atouchet commented Apr 2, 2024

The first change was fixed in #2776.

Signed-off-by: tgolang <seekseat@aliyun.com>
@tgolang
Copy link
Author

tgolang commented Apr 23, 2024

ripgrep/crates/core/messages.rs

Thanks!

@tgolang
Copy link
Author

tgolang commented Apr 23, 2024

The first change was fixed in #2776.

Thansk.

Modified

@tgolang
Copy link
Author

tgolang commented Apr 23, 2024

Please review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants