Make gitignore.rs's gitconfig_excludes_path public
#2482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2023
Eric-Arellano
added a commit
to pantsbuild/ripgrep
that referenced
this pull request
Apr 1, 2023
See BurntSushi#2482 for the upstream PR.
BurntSushi
added
the
rollup
BurntSushi
pushed a commit
that referenced
this pull request
Jul 8, 2023
I have reservations about this, but it looks useful and doesn't seem terribly onerous to support. The `ignore` crate will really always need to have some kind of logic supporting this in some form I think. Closes #2482
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pantsbuild, we use
GitignoreBuilderto determine which files our file watcher should look at.We want to improve the file watcher to consider the global gitignore file. It would be exceptionally useful if we could reuse your logic: pantsbuild/pants#18649
P.S. Thanks for ripgrep! You've saved me so much time 馃檶