Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace atty with is-terminal #2481

Closed
wants to merge 1 commit into from
Closed

Replace atty with is-terminal #2481

wants to merge 1 commit into from

Conversation

tottoto
Copy link

@tottoto tottoto commented Mar 30, 2023

Replaces atty with is-terminal as atty is unmaintained.

@BurntSushi
Copy link
Owner

Thanks for the PR! I'm going to stick with atty for now. The is-terminal crate brings in too many dependencies IMO.

It does look like the IsTerminal API in std will be landing soon. Once that's stable, we can switch to that and drop atty completely.

@BurntSushi BurntSushi closed this Mar 30, 2023
@tottoto tottoto deleted the replace-atty-with-is-terminal branch March 30, 2023 15:11
@tottoto
Copy link
Author

tottoto commented Mar 30, 2023

I understand. It makes sense. Thanks for your review.

@BurntSushi BurntSushi mentioned this pull request May 13, 2023
Closed
@Enselic Enselic mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tottoto @BurntSushi