Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit fixes a bug where AsciiDoc would drop any line containing a '{foo}' because it interpreted it as an undefined attribute reference: > Simple attribute references take the form {<name>}. If the attribute name > is defined its text value is substituted otherwise the line containing the > reference is dropped from the output. See: https://www.methods.co.nz/asciidoc/chunked/ch30.html We fix this by simply replacing all occurrences of '{' and '}' with their escaped forms: '{' and '}'. Fixes #1101
- Loading branch information
1 parent
fb62266
commit b41e596
Showing
2 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41e596
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this method too. I'd ruled it out because it requires you to micro-manage the formatting in the Rust source, but i guess it's not like a lot of different people are touching it
You probably already get this, but just to leave a reminder somewhere, in addition to not putting
{
/}
inside back-ticks, you'll also need to avoid putting them in indented literal blocks. (There aren't any instances of that in the options text right now, but there are a few--type-add
examples in the 'configuration files' section that would break if this method were applied there.) FYIb41e596
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye, thanks. And yeah, this isn't ideal. I'm not a huge fan of how it all works, but I don't have too many strenuous complaints. :)