Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected return value of getFacing() for Pumpkin #1119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

R2D2Warrior
Copy link

Both data values 0x1 and 0x3 were returning BlockFace.EAST when a data value of 0x3 should return BlockFace.WEST

Both data values 0x1 and 0x3 were returning BlockFace.EAST when a data value of 0x3 should return BlockFace.WEST
@mbax
Copy link
Member

mbax commented Dec 16, 2016

  • PR submitted to project.
  • Project dead for two years.
  • Likely to be approved.

@R2D2Warrior
Copy link
Author

Alright, then where is this project updated? I didn't bother checking the last time this was updated since current Bukkit has definitely been updated more recently.

@JeromSar
Copy link
Contributor

JeromSar commented Dec 16, 2016

@R2D2Warrior A version of (Craft)Bukkit is being maintained by Spigot.

@mbax
Copy link
Member

mbax commented Dec 16, 2016

It's worth being aware that the fork mentioned above received a DMCA takedown notice on the code (as did the CraftBukkit repo here) and, rather than respond via the appropriate legal channels, they simply migrated their code to a place that wouldn't be affected. That's why you don't see it on GitHub. I am personally aware of several US-based developers who received advice from lawyers not to touch Spigot because of this. Of course, this is not legal advice and I'm not a lawyer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants