Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B+C] Add missing effects. Adds BUKKIT-5652. #1074

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 51 additions & 1 deletion src/main/java/org/bukkit/Effect.java
Expand Up @@ -59,6 +59,42 @@ public enum Effect {
* Sound of zombies destroying a door.
*/
ZOMBIE_DESTROY_DOOR(1012, Type.SOUND),
/**
* Sound of a Wither spawning.
*/
WITHER_SPAWN(1013, Type.SOUND),
/**
* Sound of a Wither firing.
*/
WITHER_SHOOT(1014, Type.SOUND),
/**
* Sound of a bat taking off.
*/
BAT_TAKEOFF(1015, Type.SOUND),
/**
* Sound of villager getting infected.
*/
VILLAGER_INFECT(1016, Type.SOUND),
/**
* Sound of villager being cured.
*/
VILLAGER_CURE(1017, Type.SOUND),
/**
* Sound of an Enderdragon dying.
*/
ENDERDRAGON_DIE(1018, Type.SOUND),
/**
* Sound of an anvil breaking.
*/
ANVIL_BREAK(1020, Type.SOUND),
/**
* Sound of an anvil being used.
*/
ANVIL_USE(1021, Type.SOUND),
/**
* Sound of an anvil landing.
*/
ANVIL_LAND(1022, Type.SOUND),
/**
* A visual smoke effect. Needs direction as additional info.
*/
Expand All @@ -79,7 +115,21 @@ public enum Effect {
/**
* The flames seen on a mobspawner; a visual effect.
*/
MOBSPAWNER_FLAMES(2004, Type.VISUAL);
MOBSPAWNER_FLAMES(2004, Type.VISUAL),
/**
* The green particles that appear when using bonemeal on a plant.
*/
BONEMEAL_USE(2005, Type.VISUAL),
/**
* Visual effect of dust played when an entity lands on a block after
* falling from a high altitude. Needs an integer which is the particle
* speed.
* <p>
* When playing it, the location is the block the entity has fallen on,
* and is used to choose the appropiate texture based on the block
* material. The particles are rendered on top of that.
*/
LAND_DUST(2006, Type.VISUAL, Integer.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is being touched anyway, it should end the line with comma and the semicolon on the next line.


private final int id;
private final Type type;
Expand Down