Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: angular sdk styles #3273

Merged
merged 17 commits into from May 16, 2024
Merged

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented May 9, 2024

Description

This PR fixes angular sdk block styles (overall) by marking all the hosts as display: contents

Jira
https://builder-io.atlassian.net/browse/ENG-5832

Screenshot
If relevant, add a screenshot or two of the changes you made.

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 62d7300

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/sdk-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 3:40pm
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 3:40pm
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 3:40pm
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 3:40pm

@sidmohanty11 sidmohanty11 marked this pull request as ready for review May 9, 2024 07:14
@sidmohanty11 sidmohanty11 requested review from samijaber and a team as code owners May 9, 2024 07:14
@sidmohanty11 sidmohanty11 requested review from mrkoreye and removed request for a team May 9, 2024 07:16
Comment on lines +66 to +68
const builderBoxChildren = page
.locator('[builder-id="builder-258a89336ec44f37a38a146e698a858a"]')
.locator('div[builder-id]');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, glad this worked

packages/sdks-tests/src/tests/basic-styles.spec.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants