[Fix][Environments][Algolia Plugin] SUPP-298 Added safety check so that sync-to-algolia does not appear in an env's model #2959
Conversation
…at sync-to-algolia does not appear in an env's model
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
plugins/algolia/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@builder.io/plugin-algolia", | |||
| "version": "0.0.5", | |||
| "version": "0.0.6", | |||
There was a problem hiding this comment.
We do not change the version directly here.
Generally, we run publish commands present in package.json file, which do these changes automatically. Also, we publish patch and above versions, only after we verify the fix with dev version.
plugins/algolia/src/plugin.tsx
Outdated
There was a problem hiding this comment.
@shyam-builder Need your thoughts in this specific change. Is it fine if disable syncing models to algolia if we are in an env? Basically somewht disabling plugins from an env.
wdyt?
There was a problem hiding this comment.
Is there a reason why we would want to disable? I can see customers wanting to finish translation and all in a lower environment and push it up.
There was a problem hiding this comment.
Specifically what breaks from an environment?
There was a problem hiding this comment.
If the installation and usage of plugin happens in same env/space its not a problem but if installation is done in main space and the usage (webhook url syncing) is done in env, it messes up the webhook url params.
Which could lead to confusion and improper working. Happened in SUPP-298.
Thus it would be better if plugins work in main space only
Added safety check so that sync-to-algolia button does not appear, in an env's model so that changes of mixup dont arise.