support subFields showIf #2586
Draft
support subFields showIf #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
teleaziz
reviewed
Sep 28, 2023
| input = { | ||
| ...input, | ||
| [key]: `return (${fn.toString()}).apply(this, arguments)`, | ||
| ...(input.subFields == null |
There was a problem hiding this comment.
there might be a lint rule type coercion with double equeals, maybe we do this instead?
...(Array.isArray(input.subFields)
? {
subFields: input.subFields.map((input) => {
return this.convertFnToString({ keysToConvert, input });
}),
}
: {}),
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 82d3286. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch | |Sent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to support
showIfin buildersubFields.Notice
This has not been checked yet, because I don't know how to run builder.
Motivation
I want
subFieldswill be able to be shown conditionally like regular fields withshowIf.Here is an example of
showIf:https://github.com/BuilderIO/builder/assets/104710778/1037361d-b6d7-4862-94dc-7629d5eb72c3