Fix #4621 by not rendering item frames with filled maps #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix to #4621 by not trying to render filled maps in item frames, since they cause the client to crash. Render an empty item frame instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4621 Crash when looking at blueprint render containing item frame with map.
Tweaked the code rendering the blueprint preview, more specifically the method rendering entities. Changed it so in the preview, item frames with filled maps are rendered as simple empty item frames (filled by minecraft:air). This prevents the client from crashing when attempting to render the filled map.
Proposed changes have been tested and seem to work.
P.S. It might not be a super elegant fix, but definitely works, and fixes this game breaking bug. Open to other suggestions too, but looking at the fact that builders need major overhauling, until that happens it doesn't make sense to take the time to find a better solution.