Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually fix #4608 Mining Well cannot mine through flowing water blocks #4624

Open
wants to merge 1 commit into
base: 8.0.x-1.12.2
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2020

Actually fix issue #4608

This time, actually took the effort to clone, build and test the proposed changes.

Reworked logic, which finds the next block to be mined (nextPos).
Added new method, which determines if a block is traversable (canMoveThrough). This method is called in the reworked nextPos method.

Tested following cases:

  • No obstruction: mining well behaves normally.
  • Obstructed by flowing water block: Mining well goes through it and mines blocks below.
  • Obstructed by water source block: Mining well goes through it, water source block is destroyed (due to tube) and blocks are mined below.
  • Obstructed by lava (density larger then 1000): Mining well stops.
  • Obstructed by bedrock: Mining well stops.
  • Obstructed by bedrock, with minable block below: Mining well stops (does not target block below and goes through the bedrock).

- Updated method which locates the next block to be targetted
- Added new method do determine wether a block can be traversed or not
@ghost ghost changed the title Actually fix #4608 Mining Well cannot mine through flowing water blocks.mining well cant Actually fix #4608 Mining Well cannot mine through flowing water blocks Dec 13, 2020
@Aitormantilla
Copy link

I want to fix this bug in my world but i dont known how to change the code. Can you send the mod fixed? I have been trying to fix it but I didnt found anything. Thanks

@asiekierka
Copy link
Member

Please don't waltz into pull requests just to be rude to others, @JukoiDev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants