Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support attachment columns in Automations #13567

Merged
merged 25 commits into from May 9, 2024
Merged

Support attachment columns in Automations #13567

merged 25 commits into from May 9, 2024

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Apr 26, 2024

Description

This PR adds support for attachment columns within automations

  • Adding attachments using the Create / Update row actions
  • Support for both single and multiple attachment columns
  • Refactors some of the code out of the Send Email block for common use between actions

Addresses

https://linear.app/budibase/issue/BUDI-6867/automations-dont-support-attachment-fields

App Export

Screenshots

image

Launchcontrol

  • Adds the ability for the user to add attachments from within the Create Row / Update Row automation steps.

@PClmnt PClmnt requested a review from a team as a code owner April 26, 2024 09:24
@PClmnt PClmnt requested review from adrinr and removed request for a team April 26, 2024 09:24
@PClmnt
Copy link
Collaborator Author

PClmnt commented Apr 26, 2024

Will get some tests in for this as well

@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label Apr 26, 2024
@PClmnt PClmnt added the feature-branch Release this PR code into a feature branch label May 8, 2024
samwho
samwho reviewed May 8, 2024
View reviewed changes
packages/backend-core/src/objectStore/utils.ts Outdated Show resolved Hide resolved
packages/server/src/automations/automationUtils.ts Outdated Show resolved Hide resolved
packages/server/src/automations/automationUtils.ts Outdated Show resolved Hide resolved
packages/server/src/automations/automationUtils.ts Outdated Show resolved Hide resolved
packages/server/src/automations/automationUtils.ts Outdated Show resolved Hide resolved
packages/server/src/automations/automationUtils.ts Show resolved Hide resolved
packages/server/src/automations/tests/createRow.spec.ts Outdated Show resolved Hide resolved
packages/worker/src/utilities/email.ts Outdated Show resolved Hide resolved
samwho
samwho approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with my feedback, this is looking good!

mike12345567
mike12345567 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well - thanks for going through the PR comments!

@PClmnt PClmnt merged commit db273bc into master May 9, 2024
10 checks passed
@PClmnt PClmnt deleted the feat/support-attachments-in-automations branch May 9, 2024 13:30
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samwho samwho samwho approved these changes

@mike12345567 mike12345567 mike12345567 approved these changes

@adrinr adrinr Awaiting requested review from adrinr adrinr is a code owner automatically assigned from Budibase/backend

Assignees
No one assigned
Labels
feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PClmnt @samwho @mike12345567