Improve navbar readability and add logo. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Binari developers. I am a first time contributor, and my experience using React with Babel is limited.
One of the first things I noticed when visiting https://binari.dev is that the navbar text doesn't have optimal readability. To address this, I changed the font size and font weight of the navbar links.
Before (top) and after (bottom) of the navbar when the parallax effect is not active (i.e. the page is scrolled to the top)
Before (top) and after (bottom) of the navbar when the parallax effect is active (i.e. the page is scrolled down)
I hope these changes seem reasonable and actionable in your eyes. Since I am not very experienced using React, I understand that these changes may not use the best conventions. If you agree with the design change, please feel free to create a new PR implementing these changes with better programming conventions.
Note: This pull request has been opened for credit in a university course.