Added downloadBytes callback to RawDataOutput #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added downloadBytes callback to RawDataOutput, to make it symmetrical with the uploadBytes method in RawDataInput. Fixed bugs in the Luminance format for RawDataInput and RawDataOutput.
| framebuffer.unlock() | ||
|
|
||
| var data = [UInt8](count:Int(framebuffer.size.width * framebuffer.size.height * 4), repeatedValue:0) | ||
| glReadPixels(0, 0, framebuffer.size.width, framebuffer.size.height, GLenum(GL_RGBA), GLenum(GL_UNSIGNED_BYTE), &data) | ||
| renderFramebuffer.unlock() | ||
|
|
||
| dataAvailableCallback?(data) | ||
| if dataAvailableCallback != nil { |
There was a problem hiding this comment.
You already using optional chaining when calling dataAvailableCallback closure, so there is no need to check against nil value ;)
There was a problem hiding this comment.
Thanks for pointing these out. Creating another pull request.
rhx
pushed a commit
to rhx/GPUImage
that referenced
this pull request
Oct 13, 2019
Add Median Filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added downloadBytes callback to RawDataOutput, to make it symmetrical
with the uploadBytes method in RawDataInput.
Fixed bugs in the Luminance format for RawDataInput and RawDataOutput.