Fix pixel color calculation for different data formats #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbovasia
reviewed
Feb 12, 2024
| for yCoordonate in 0 ..< cgImage.height { | ||
| for xCoordonate in 0 ..< cgImage.width { | ||
| let index = (cgImage.width * yCoordonate + xCoordonate) * 4 | ||
| for yCoordonate in 0 ..< imageHeight { |
There was a problem hiding this comment.
yCoordonate should be replaced with yCoordinate, xCoordonate should be replaced with xCoordinate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way pixel data is obtained from image in
dominantColorFrequencies.Previously, raw image data was retrieved from CGImage and assumed to be in a RGBA8 format (meaning each pixel has 4 bytes, with R, G, B and A values in this order). However, this is not guaranteed, and if the image was in a different format, the algorithm returned wrong values.
This PR adds conversion from CGImage to CIImage, and uses CIContext to render the image to a bitmap buffer. This ensures that the image data is always in RGBA8 format.