-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding homework 3 #32
base: master
Are you sure you want to change the base?
Conversation
Hey Peter, this pull request has some merge conflicts that prevent me from accepting it. I got your homework, though, so you're fine for now. We'll want to fix this asap, though. You have 2 options:
These are the conflicting files:
There's a difference between what your Github fork has remotely, and what you have locally (on your computer) with git, and the differences are specifically in those files. Github is asking you to choose what you want to keep. To sync this, you'll need to add, commit, and pull down from the class homework repo, add, commit, then push everything back up.
This should resolve the merge conflict issue. :) |
|
||
|
||
(function randomAddy() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent use of an IIFE! :)
return(Math.ceil(Math.random()*6)) | ||
} | ||
function random2() { | ||
return(Math.ceil(Math.random()*6)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just invoke the random1()
and random2()
functions you defined above on lines 20 and 26 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another great example of why scope is so important - you have two functions with identical names in the same file, but fortunately they do the same thing. What if they did something different? When you call random2()
, which function would run?
Hi Nicole, adding all files from HW3.