Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF Exports: New command option and library/option cleanup #4969

Merged
merged 4 commits into from Apr 26, 2024
Merged

PDF Exports: New command option and library/option cleanup #4969

merged 4 commits into from Apr 26, 2024
+211 −246

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Apr 22, 2024 •
edited

Implementation from thoughts/ideas of #4732.
Also simplifies/organises config for exports, and removes some intermediate dependencies.

References

Todo

  • Review unwrapping snappyPDF like DomPDF.
  • Update existing snappy code to support new options format.
  • Complete implementation for new command option.
  • Testing:
    • Cover new command option.
    • Ensure DomPDF export still works and uses app options.
    • Ensure WKHTMLtoPDF export still works and uses app options.
    • Manual test of command option on Windows.

Docs Updates

  • Document new command option, along with example.
  • Update old WKHTMLtoPDF option to indicate deprecation.

@ssddanbrown
PDF: Started new command option, merged options, simplified dompdf
bb6670d 
- Updated DOMPDF to direcly use library instead of depending on barry
wrapper.
- Merged existing export options file into single exports file.
- Defined option for new command option.

Related to #4732
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Apr 22, 2024
@ssddanbrown ssddanbrown self-assigned this Apr 22, 2024
@ssddanbrown
PDF: Removed barryvdh snappy to use snappy direct
4020085 
Also simplifies config format, and updates snappy implmentation to use
the new config file.
Not yet tested.
@ssddanbrown
PDF: Added implmentation of command PDF option
1c7128c 
Tested quickly manually but not yet covered by PHPUnit tests.
@ssddanbrown
PDF: Added tests for pdf command, fixed old tests for changes
f0dd33c
@ssddanbrown ssddanbrown merged commit e1149a2 into development Apr 26, 2024
17 of 18 checks passed
@ssddanbrown ssddanbrown mentioned this pull request Apr 26, 2024
Closed
6 tasks
@ssddanbrown ssddanbrown deleted the pdf_command_option branch May 8, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
📖 Docs Update 🏭 Back-End 🔨 Feature Request 🚚 Export System 🔧 Maintenance
Milestone
v24.05
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ssddanbrown