Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python feedback changes #942

Merged
merged 8 commits into from May 13, 2024
Merged

Python feedback changes #942

merged 8 commits into from May 13, 2024

Conversation

JDuffeyBQ
Copy link
Collaborator

@JDuffeyBQ JDuffeyBQ commented May 1, 2024

Some changes are for #913

  • No longer require name argument on Pipeline.to_file
  • Added Pipeline.to_json_str
  • Added Pipeline.name
  • Added PipelineFilter.comments
  • IFilter::toJson now uses default values when the value in the arguments doesn't exist instead of failing
  • Fixed the lifetime of docstrings generated at runtime
  • Removed registerPluginPyFilters

@JDuffeyBQ JDuffeyBQ force-pushed the python/feedback branch 4 times, most recently from a7ba12f to b141a92 Compare May 3, 2024 16:13
* Now throw exception on file error
* Now writes pipeline with indent of 2 and newline at EOF

Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
@JDuffeyBQ JDuffeyBQ marked this pull request as ready for review May 10, 2024 20:31
@JDuffeyBQ JDuffeyBQ merged commit 984e51a into develop May 13, 2024
8 checks passed
@JDuffeyBQ JDuffeyBQ deleted the python/feedback branch May 13, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants