Skip to content

Commit

Permalink
Fixed filter widgets not being destructed
Browse files Browse the repository at this point in the history
* Changed PipelineItem::setFilterInputWidget to private

Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
  • Loading branch information
JDuffeyBQ committed Feb 18, 2021
1 parent 40e9e53 commit 1d8ba0b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions Source/SVWidgetsLib/Widgets/PipelineItem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ PipelineItem::PipelineItem(const QVector<QVariant>& data, PipelineItem* parent)
PipelineItem::~PipelineItem()
{
qDeleteAll(m_ChildItems);
m_FilterInputWidget->deleteLater();
}

// -----------------------------------------------------------------------------
Expand Down
9 changes: 5 additions & 4 deletions Source/SVWidgetsLib/Widgets/PipelineItem.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ class SVWidgetsLib_EXPORT PipelineItem
PipelineItem(const QVector<QVariant>& data, PipelineItem* parent = nullptr);
virtual ~PipelineItem();

/**
* @brief Setter property for FilterInputWidget
*/
void setFilterInputWidget(FilterInputWidget* value);
/**
* @brief Getter property for FilterInputWidget
* @return Value of FilterInputWidget
Expand Down Expand Up @@ -323,6 +319,11 @@ class SVWidgetsLib_EXPORT PipelineItem

void setupFilterInputWidget();

/**
* @brief Setter property for FilterInputWidget
*/
void setFilterInputWidget(FilterInputWidget* value);

public:
PipelineItem(const PipelineItem&) = delete; // Copy Constructor Not Implemented
PipelineItem(PipelineItem&&) = delete; // Move Constructor Not Implemented
Expand Down

0 comments on commit 1d8ba0b

Please sign in to comment.