Abtract backend stuff #2711
Open
Abtract backend stuff #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaeHagen
commented
Apr 5, 2024
TaeHagen
commented
Apr 5, 2024
lib/app/layouts/conversation_view/widgets/message/popup/message_popup.dart
Show resolved
Hide resolved
tneotia
requested changes
Apr 19, 2024
There was a problem hiding this comment.
So far nothing super major. The only thing I will add here thats overarching is that I think it would be awesome if rather than checking getRemoteService for things that RustPush can't do, is that the backend has actual getters to check for these things. For example backend.canFetchGroupChatIcon. Not saying we will ever become a matrix client, but if someone wants to integrate another backend, its quite possible that it has a remote service but that isn't a thing for them. Just food for thought, I know itll be a bit more work but I think that would be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New and improved abstractions!